-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose "is TLS enabled" flag for Kibana HTTP Server #40336
Conversation
Pinging @elastic/kibana-platform |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the security perspective and does what we need in #39446
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small naming nit
src/core/server/http/http_server.ts
Outdated
@@ -75,6 +75,7 @@ export interface HttpServerSetup { | |||
isAuthenticated: AuthStateStorage['isAuthenticated']; | |||
getAuthHeaders: AuthHeadersStorage['get']; | |||
}; | |||
isTLSEnabled: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be capitalized isTlsEnabled
to be consistent with HttpServer
and SslConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
💚 Build Succeeded |
* expose it TLS enabled on Http server * setup contract is under one section in tests * regenerate docs * isTLSEnabled --> isTlsEnabled
* expose it TLS enabled on Http server * setup contract is under one section in tests * regenerate docs * isTLSEnabled --> isTlsEnabled
Summary
Expose boolean flag indicating if TLS enabled for Kibana HTTP server.
The frist commit introduces flag.
The second one restructures tests to move all
setup contract
related tests under one section.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers